FolderChooserSelectionListener NPE collapsing tree

[ericam33]

Hi,

When i use FolderChooser to select some paths to add to a project, and while navigating the available directories, i then collapse the top level directory in my folderchooser i get this exception. I'm using version 2.2.6 of the jide-components jar.

int result = folderChooser.showDialog(parent, folderChooser.getApproveButtonText());
java.lang.NullPointerException
at com.jidesoft.plaf.basic.BasicFolderChooserUI$FolderChooserSelectionListener.valueChanged(Unknown Source)
at javax.swing.JTree.fireValueChanged(Unknown Source)
at javax.swing.JTree$TreeSelectionRedirector.valueChanged(Unknown Source)
at javax.swing.tree.DefaultTreeSelectionModel.fireValueChanged(Unknown Source)
at javax.swing.tree.DefaultTreeSelectionModel.notifyPathChange(Unknown Source)
at javax.swing.tree.DefaultTreeSelectionModel.removeSelectionPaths(Unknown Source)
at javax.swing.JTree.removeDescendantSelectedPaths(Unknown Source)
at javax.swing.JTree.setExpandedState(Unknown Source)
at javax.swing.JTree.collapsePath(Unknown Source)
at javax.swing.plaf.basic.BasicTreeUI.toggleExpandState(Unknown Source)
at javax.swing.plaf.basic.BasicTreeUI.handleExpandControlClick(Unknown Source)
at javax.swing.plaf.basic.BasicTreeUI.checkForClickInExpandControl(Unknown Source)
at javax.swing.plaf.basic.BasicTreeUI$Handler.handleSelection(Unknown Source)
at javax.swing.plaf.basic.BasicTreeUI$Handler.mousePressed(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.Dialog$1.run(Unknown Source)
at java.awt.Dialog$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.Dialog.show(Unknown Source)
at javax.swing.JFileChooser.showDialog(Unknown Source)
at com.iona.artix.ds.FolderChooserHelper.showDialog(FolderChooserHelper.java:108)
at com.iona.artix.ds.designer.dialog.settings.ProjectPathsPanel.actionPerformed(ProjectPathsPanel.java:113)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.Dialog$1.run(Unknown Source)
at java.awt.Dialog$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.Dialog.show(Unknown Source)
at com.jidesoft.dialog.StandardDialog.show(Unknown Source)
at java.awt.Component.show(Unknown Source)
at java.awt.Component.setVisible(Unknown Source)
at java.awt.Window.setVisible(Unknown Source)
at java.awt.Dialog.setVisible(Unknown Source)
at com.iona.artix.ds.designer.action.project.ProjectPropertiesAction.openProperties(ProjectPropertiesAction.java:40)
at com.iona.artix.ds.designer.action.project.ProjectPropertiesAction.actionPerformed(ProjectPropertiesAction.java:33)


ProjectPropertiesAction is simply calling

ProjectPropertiesDialog d = new ProjectPropertiesDialog(getParent(), getParent().getProject());
d.setVisible(true);

I cannot upgrade the version of the jar without having to address numerous other bugs so the only option i see is to override BasicFolderChooserUI and try to fix the NPE.

Any suggestions?
Thanks
erica

[JIDE Support]

Could you please create a test case for it? I need to know exactly which line causes the NPE so that I can think of a solution without upgrading, if possible at all.

Thanks,

[ericam33]

My test case wasnt throwing the exception so it must be something i'm doing with updating the recent file list.
I did check out the 2.2.6 branch and attach the code to trace the NPE from within my application to this line in FolderChooserSelectionListener.valueChanged()

String folderPath = (e.getNewLeadSelectionPath().getLastPathComponent()).toString();

e.getNewLeadSelectionPath is null.

[ericam33]

I see that in the trunk version of the same file, it does a check first to make sure something is selected
if (_fileSystemTree.getSelectionCount() > 0) {
String folderPath = (e.getNewLeadSelectionPath().getLastPathComponent()).toString();

[JIDE Support]

I just added an NPE check for getNewLeadSelectionPath() to make sure.

Thanks,

[JIDE Support]

Just so you know, 2.5.0 release should fix this NPE.

Thanks,