Has JideToggleSplitButton ever worked for anybody?

[eiro7Xoo]

Today I tried JideToggleSplitButton (JIDE 1.9.3), and the toggle/untoggle functionality does not work. So I downloaded the most recent stable version 2.4, to see whether it has been fixed already. Apparently not.

Here's the code to reproduce, further down I have a (quick and dirty) fix. Just execute the main method and click the buttons, only one should be active at any time, as they are toggle buttons in a button group. If it looks weird for you, good! You reproduced the bug.

Code: Select all

package com.jidesoft.swing;

import javax.swing.*;
import java.awt.*;

public class JideToggleSplitButtonTest {


    public static void main(String[] args) throws Exception {

        JPanel panel = new JPanel();
        final ButtonGroup buttonGroup = new ButtonGroup();

        panel.add(t("b1", buttonGroup));
        panel.add(t("b2", buttonGroup));
        panel.add(t("b3", buttonGroup));

        JFrame frame = new JFrame("ToggleTest");
        frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
        frame.getContentPane().add(panel, BorderLayout.NORTH);
        frame.pack();
        frame.setVisible(true);

    }

    private static AbstractButton t(String s, ButtonGroup bg) {
        JideToggleSplitButton b = new JideToggleSplitButton(s);
        b.setActionCommand(s);
        b.setFocusable(false);
        if (bg != null) bg.add(b);
        b.add(new JMenuItem(s + " menu"));
        return b;
    }

}


Add the following method to JideToggleSplitButton.ToggleSplitButtonModel and toggling/untoggling will work.

Code: Select all

/**
 * Calls from ButtonGroup will be redirected to setButtonSelected(boolean).
 * @param b true selects the menu (or toggle button if called from ButtonGroup), false deselects it
 */
@Override
public void setSelected(boolean b) {
    StackTraceElement[] stackFrame = Thread.currentThread().getStackTrace();
    for (int i = 0; i < 5 && i < stackFrame.length; i++) {
        if ("javax.swing.ButtonGroup".equals(stackFrame[i].getClassName())) {
            setButtonSelected(b);
            return;
        }
    }
    super.setSelected(b);
}


It's ugly, but due to the ambiguity of setSelected (MenuItem vs. Button) I don't know whether there's an easy cleaner fix. Neither did I do extensive tests for side effects and regression. Maybe someone familiar with Jide/Swing internals can share their view on this or propose a better solution.

[JIDE Support]

You need to use SplitButtonGroup instead of ButtonGroup for JideSplitButtons.

Thanks,

[eiro7Xoo]

Now that was easy. Thanks.

Where is this documented? I guess it would make sense to add a little heads-up to the class documentation of JideToggleSplitButton so other people don't have to spend hours of head scratching, googling, checking out the most recent sources, debugging, work-arounding etc. Something like this would have done it for me:

Code: Select all

/**
 * An implementation of a two-state JideButton.
 * <p>
 * <strong>Warning:</strong>
 * {@code SplitButtonGroup} has to be used in place of {@code ButtonGroup} for {@code JideToggleSplitButton}s.
 */


[JIDE Support]

The javadoc of SplitButtonGroup mentioned but we should add it to JideSplitButton. I will do that.

[eiro7Xoo]

You mean "we should add it to JideToggleSplitButton", I guess.

[JIDE Support]

That's correct.

[JIDE Support]

Just so you know, the javadoc is added in 2.4.6 which is just released.

Thanks,

[eiro7Xoo]

Thanks.